Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: frozen pinning service modal error #1841

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 23, 2021

Fixes #1816: now, when the input changes, we clear the errors from the form. The issue was that handleSubmit was not calling our actual onSubmit function since there were validation errors.

Regarding the second issue described by OP in #1816 (comment), I could not reproduce.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias self-assigned this Aug 23, 2021
@hacdias hacdias temporarily deployed to Deploy August 23, 2021 10:03 Inactive
This ensures we show "Failed to fetch" only when
ipfs pin remote service ls --stat
fails, and not when we are waiting for it to complete.
@lidel lidel temporarily deployed to Deploy September 1, 2021 00:34 Inactive
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! works as expected + I've added small UX fix.

@lidel lidel merged commit d43dc62 into main Sep 1, 2021
@lidel lidel deleted the fix/frozen-pinning-service-error branch September 1, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"Add Service" modal stuck in "Service Already Present" state
2 participants