Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Service" modal stuck in "Service Already Present" state #1816

Closed
Jan877 opened this issue Jul 4, 2021 · 6 comments · Fixed by #1841
Closed

"Add Service" modal stuck in "Service Already Present" state #1816

Jan877 opened this issue Jul 4, 2021 · 6 comments · Fixed by #1841
Assignees
Labels
area/pinning Integrating pinning into GUI apps effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/stale P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Milestone

Comments

@Jan877
Copy link

Jan877 commented Jul 4, 2021

@lidel's summary of the underlying bug

See #1816 (comment)

Original report

Service Already Present

NFT

  • OS: Windows 10
  • Version of IPFS Desktop: 2.12.3

Describe the bug
By mistake, I removed the Pinning Service Pinata. I was playing around with another pinning service. However, I decided I wanted to redownload Pinata. I got a message in IPFS : "Service Already Present." but I was not able to add Pinata in the list over pinning services. The only pinning service I can see is Local node.
.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings | IPFS'
  2. Click on 'Add Service'
  3. Enter Pinata API endpoint and password
  4. The message "Service Already Present" is shown and Pinata isn't added to IPFS

Expected behavior
I expected to be able to add Pinata in IPFS again, although I had deleted it by mistake

Screenshots
Please see attachment.

Additional context
N/A.

@ipfs ipfs deleted a comment from welcome bot Jul 5, 2021
@lidel
Copy link
Member

lidel commented Jul 5, 2021

Thank you @Jan877 – It is a bug in GUI.
You can work around this by closing modal via "Cancel" and then trying to "Add Service" again, using a unique name, before pressing "Save" for the first time.


Notes for person fixing this:

How to Reproduce

I was able to reproduce. There seems to be a bug where it is impossible to submit the form after name change.

  1. Add Pinata
  2. Try to add it again under same name, there will be "Service Already Present: error:

    2021-07-05--19-50-26
    and expected error logged in console:
    2021-07-05--19-51-34

  3. In the same modal, change nickname to something unique and try to submit again. Nothing happens, the old error is still displayed, there is no new error in console:

    2021-07-05--19-51-01

@lidel lidel changed the title Service Already Present "Add Service" modal stuck in "Service Already Present" state Jul 5, 2021
@lidel lidel transferred this issue from ipfs/ipfs-desktop Jul 5, 2021
@lidel lidel added this to the v2.12 milestone Jul 5, 2021
@lidel lidel added area/pinning Integrating pinning into GUI apps effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Jul 5, 2021
@lidel lidel added status/ready Ready to be worked help wanted Seeking public contribution on this issue labels Jul 5, 2021
@Jan877
Copy link
Author

Jan877 commented Jul 18, 2021

Thank you @Jan877 – It is a bug in GUI.
You can work around this by closing modal via "Cancel" and then trying to "Add Service" again, using a unique name, before pressing "Save" for the first time.

Notes for person fixing this:

How to Reproduce

I was able to reproduce. There seems to be a bug where it is impossible to submit the form after name change.

  1. Add Pinata
  2. Try to add it again under same name, there will be "Service Already Present: error:

    2021-07-05--19-50-26
    and expected error logged in console:
    2021-07-05--19-51-34

  3. In the same modal, change nickname to something unique and try to submit again. Nothing happens, the old error is still displayed, there is no new error in console:

    2021-07-05--19-51-01

Hello lidel,
I followed your instructions for the work around. I used a unique name. Saved the name and then entered the "API endpoint" and "Secret Access Token".
However, the new unique name was still not added to the list over Pinning Services. The only pinning service that is shown is "Local Pinning".

@lidel
Copy link
Member

lidel commented Aug 6, 2021

@Jan877 unable to reproduce, need more info from you:

  1. are you running the latest ipfs-desktop? https://github.com/ipfs/ipfs-desktop/releases
  2. how do you access webui? browser? ipfs-desktop?
  3. is it still missing when you refresh the page or Quit ipfs-desktop and start it again?

@lidel lidel added need/author-input Needs input from the original author and removed need/author-input Needs input from the original author labels Aug 6, 2021
@github-actions
Copy link
Contributor

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

@github-actions
Copy link
Contributor

This issue was closed because it is missing author input.

@github-actions
Copy link
Contributor

This issue was closed because it is missing author input.

@hacdias hacdias reopened this Aug 31, 2021
@hacdias hacdias removed the need/author-input Needs input from the original author label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pinning Integrating pinning into GUI apps effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/stale P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants