-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'ipfs' to PATH on Windows #897
Conversation
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly I don't have Windows VM to test this :'(
@djdv are you able to do a quick check, or know who can?
(npm ci && npm run build
will output installer to dist/
, I think)
I encountered an unrelated issue with |
Per @djdv feedback, I'm merging this PR 😄 Thanks for checking it out. |
During installation, append
ipfs-desktop/assets/bin-win
to thePATH
on Windows. It's also removed during installation. The directory contains a script that executes our bin script that redirects the arguments to the actual binary. That way we have some flexibility about what we can do in the future.The code used to manipulate the
PATH
comes from this resources:Also, I had to disable "warnings as errors" because Electron Builder is using Macros for custom install and uninstall sections so when building the installer, NSIS didn't know if we were calling the functions in the correct places. It threw a warning that was treated as an error. Not anymore.
Addresses #727.