fix: added daemon functions to the auto-updater

[rafaelramalho19]

Fixes #1508, fixes #1496, fixes #1375

• I'm not able to test this for sure because autoUpdater doesn't work on dev mode.

The problem was that the autoUpdater was trying to access the stopIpfs from the context (ctx variable), but that would only be initialized with the functions after setupDaemon has been executed.

[hacdias]

LGTM (makes sense mentally); but leaving this as a ref #1385. Update: Also, I think checkForUpdates is used somewhere in Tray so if the user is fast enough to call the function, it may break. I'd check that.

[lidel]

I agree, this should fix stopIpfs call in:

https://github.com/ipfs-shipyard/ipfs-desktop/blob/6175b7bc0202f85f2d27ab105124b495f59bd824/src/auto-updater/quit-and-install.js#L13

However, note that auto update is the critical feature of Desktop app and must be extremely robust. Right now, afaik, if stopIpfs throws, update does not happen.

To be on the safe side I'd tweak quit-and-install.js and wrap that stopIpfs call in try/catch/finally and put autoUpdater.quitAndInstall in the finally block, so it is ALWAYS executed – even if unexpected error occurs during stopIpfs, like we observe now, or in the future, when we refactor things around.

Thoughts?

[lidel]

lgtm, @rafaelramalho19 feel free to merge & release
(I believe this is important enough to be shipped as patch release v0.11.4)