fix: call stopIpfs on ctx

[hacdias]

This fixes #1375 by calling stopIpfs on ctx. I think that deconstructing ctx may be causing that error if and only if quitAndInstall was being called before setupDaemon finished executing.

Please validate if this makes sense @lidel.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

[lidel]

Hmmmmmmmm.. it is bit late for me so please double check below, but I don't believe destructuring is the problem.

Note how ctx.stopIpfs is defined:

https://github.com/ipfs-shipyard/ipfs-desktop/blob/6ad7f6d11b781fedbf230cd0e600ceaf103edeed/src/daemon/index.js#L116

It is not a function, but a status object:

https://github.com/ipfs-shipyard/ipfs-desktop/blob/6ad7f6d11b781fedbf230cd0e600ceaf103edeed/src/daemon/index.js#L40-L43

which is one of those numbers:

https://github.com/ipfs-shipyard/ipfs-desktop/blob/f7891f3c01aa4557840b9bf5f3278fbdf6daef75/src/daemon/index.js#L9-L16

[hacdias]

@lidel ctx.stopIpfs seems to be a function:

 const runAndStatus = (fn) => async () => { 
   await fn() 
   return status 
 } 

Calling runAndStatus returns a function and it does not execute what's inside unless it's called again.

[hacdias]

@lidel I agree with you that this is not the root cause of that problem. It doesn't make sense and the user must be really fast (probably impossible) to make this happen. I'll close this and see if I can reproduce.