Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inconsistent EnumerateChildrenAsync behavior #41

Merged
merged 2 commits into from
Jul 11, 2019
Merged

fix inconsistent EnumerateChildrenAsync behavior #41

merged 2 commits into from
Jul 11, 2019

Commits on Jul 11, 2019

  1. fix inconsistent EnumerateChildrenAsync behavior 

    This fixes the inconsistent EnumerateChildrenAsync behavior by renaming
everything.

1. EnumerateChildrenAsync has been renamed to WalkParallel because (a) it
visited the root so EnumerateChildren was incorrect and (b) it isn't async.
2. EnumerateChildren has been renamed to Walk and now _also_ visits the root for
consistency.

Anyone needing to skip the root can do so manually (`if c.Equals(root)` ...).
    @Stebalien
    Stebalien committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    5d52f02 View commit details
    Browse the repository at this point in the history

  2. nit: avoid copying CIDs

    @Stebalien
    Stebalien committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    0db465e View commit details
    Browse the repository at this point in the history