fix inconsistent EnumerateChildrenAsync behavior #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the inconsistent EnumerateChildrenAsync behavior by renaming everything. 1. EnumerateChildrenAsync has been renamed to WalkParallel because (a) it visited the root so EnumerateChildren was incorrect and (b) it isn't async. 2. EnumerateChildren has been renamed to Walk and now _also_ visits the root for consistency. Anyone needing to skip the root can do so manually (`if c.Equals(root)` ...).
|
Take heed @ipfs/wg-go-core. |
Jorropo
pushed a commit
to ipfs/boxo
that referenced
this pull request
Mar 15, 2023
fix inconsistent EnumerateChildrenAsync behavior This commit was moved from ipfs/go-merkledag@625228c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the inconsistent EnumerateChildrenAsync behavior by renaming everything.
Anyone needing to skip the root can do so manually (
if c.Equals(root)...).This is an intentionally breaking change to force an audit of all callsites.
Q: Should we leave an (additional) EnumerateChildren function? That function does exactly what it says already.