Remove assertion with gauranteed flaky behavior #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove checking for cleared requests in test of network errors on block send. When a network error occurs on a block send, it will error the request and clear it out. However, it is still possible the execution of the selector query was already complete, in which case, there will not be any clearing of the request. That's ok.
willscott
approved these changes
Sep 29, 2021
This was referenced Oct 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Fix #193
Implementation
The root problem is this test is testing something not gauranteed to happen, even when response manager behaves correctly.
Essentially, when a network send error occurs, we want to interrupt execution of a response.. However, it is still possible
the execution of the selector query is already complete, even if there are still blocks waiting to be sent over the network. In this case, there will not be any clearing of the request. That's ok.