Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake] TestNetworkErrors/network_error_block_send #193

Closed
Stebalien opened this issue Aug 5, 2021 · 0 comments · Fixed by #228
Closed

[flake] TestNetworkErrors/network_error_block_send #193

Stebalien opened this issue Aug 5, 2021 · 0 comments · Fixed by #228
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/test Testing work P2 Medium: Good to have, but can wait until someone steps up

Comments

@Stebalien
Copy link
Member 

  === RUN   TestNetworkErrors/network_error_block_send
      channelassertions.go:72: 
          	Error Trace:	channelassertions.go:72
          	            				channelassertions.go:48
          	            				responsemanager_test.go:1037
          	            				responsemanager_test.go:629
          	Error:      	Not equal: 
          	            	expected: 0
          	            	actual  : 1
          	Test:       	TestNetworkErrors/network_error_block_send
          	Messages:   	should clear request
@Stebalien Stebalien added kind/test Testing work need/triage Needs initial labeling and prioritization labels Aug 5, 2021
@Stebalien Stebalien mentioned this issue Aug 5, 2021
Merged
@hannahhoward hannahhoward added effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Sep 28, 2021
@hannahhoward hannahhoward mentioned this issue Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/test Testing work P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove assertion with gauranteed flaky behavior ipfs/go-graphsync
2 participants
@Stebalien @hannahhoward