Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Don't return errors on closed exchange #15

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Don't return errors on closed exchange #15

merged 1 commit into from
Jan 20, 2019

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jan 20, 2019

@ghost ghost assigned magik6k Jan 20, 2019
@ghost ghost added the status/in-progress In progress label Jan 20, 2019
schomatis
schomatis reviewed Jan 20, 2019
View reviewed changes
blockservice.go Outdated Show resolved Hide resolved
schomatis
schomatis approved these changes Jan 20, 2019
View reviewed changes
Copy link
Contributor

@schomatis schomatis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a nice improvement, I still feel like the blockservice is closed text is a misleading error since I've found that this was failing because actually Bitswap was closed.

@magik6k
Copy link
Member Author

magik6k commented Jan 20, 2019

Changed the text to something better

@schomatis
Copy link
Contributor

Yes! Thanks.

@schomatis schomatis merged commit 95d8898 into master Jan 20, 2019
@ghost ghost removed the status/in-progress In progress label Jan 20, 2019
@Stebalien Stebalien mentioned this pull request Jan 22, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schomatis schomatis schomatis approved these changes

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees

@magik6k magik6k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The MFS root state isn't saved if the daemon is stopped with Ctrl+C
2 participants
@magik6k @schomatis