Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ignoring errors from the exchange in the blockservice #4623

Closed
Stebalien opened this issue Jan 29, 2018 · 1 comment
Closed

Consider ignoring errors from the exchange in the blockservice #4623

Stebalien opened this issue Jan 29, 2018 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@Stebalien
Copy link
Member

Currently, the blockservice can succeed in adding a block and then fail because it fails somewhere when telling the exchange we have the block.

We should probably just log and ignore (and, maybe, change the HasBlock signature on the exchange to not return an error).

@Stebalien Stebalien changed the title Consider ignoring errors from the extenge in the blockservice Consider ignoring errors from the exchange in the blockservice Jan 29, 2018
@Stebalien Stebalien mentioned this issue Jan 29, 2018
1 task
@Stebalien Stebalien added the kind/enhancement A net-new feature or improvement to an existing feature label Jan 30, 2018
@cannium
Copy link

cannium commented Sep 20, 2018

I happen to encounter the comments when reading related code. Some thoughts:

  • exchange.HasBlock return error only if the write to datastore fails. If it fails, would peers know the new blocks?(haven't read about bitswap...) If not, then we should not simply ignore the error, at least make it optional for users to choose.
  • Would some kind of batch processing be useful here, like exchange.HasBlocks ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants