Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building slim and current default. #31

Merged

Conversation

mathematicalmichael
Copy link
Contributor

@mathematicalmichael mathematicalmichael commented Oct 1, 2020

starting work on #27

this initial PR replaces the current workflow with two in parallel which check not only the integrity of the build options, but also that the image can actually build.
I may or may not keep the "split files" approach. Can't decide which I prefer. Thoughts? My thinking was that main.yml was growing very long.

@mathematicalmichael
Copy link
Contributor Author

hm for some reason it's re-building itself when start_local is run. Not sure why it's not using cached layers, but I'll fix this with adding a makefile which separates building from running. start_local sounds like it should start something that exists, not build it.

@ChristophSchranz
Copy link
Collaborator

hm for some reason it's re-building itself when start_local is run. Not sure why it's not using cached layers, but I'll fix this with adding a makefile which separates building from running. start_local sounds like it should start something that exists, not build it.

Yes, start_local is meant to build and run the image in one line of code.

@ChristophSchranz ChristophSchranz merged commit ea992d3 into iot-salzburg:master Oct 1, 2020
@ChristophSchranz
Copy link
Collaborator

Super that you found the time for this PR! 🎉

@mathematicalmichael
Copy link
Contributor Author

ah! I wasn't expecting this to get merged. I want to finish a bunch more changes but wanted to get this started testing against your repo. This doesn't actually add any features to the repo.

I'll open up another PR when I get more time to, but you can already docker pull gupyter/minimal-notebook (see the PR in my fork)

I still have to do the refactors so that we tag with the same patterns as the original docker stacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants