Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple-pay): update for version 3 of the Apple Pay plugin. #2177

Merged
merged 1 commit into from
Dec 8, 2017

Conversation

ajcrites
Copy link
Contributor

@ajcrites ajcrites commented Dec 5, 2017

trueflywood's fork is currently used for this plugin. I'm changing it back to the original which contains the current changes and also includes type definitions and methods for the new version as well as documentation updates.

The diff here is a little weird and some things were not changed although they are showing up in the diff. A summary of changes:

  • Updated repo to match the one used for cordova-plugin-applepay which is the most up-to-date
  • Added a couple more types for transaction completion and new methods
  • Organized IPaymentResponse type and updated to match plugin response
  • Added IOrderItemsAndShippingMethods type used by the new update method. IOrder can extend from this type, and now billing/shipping requirements can be an array
  • Added selected shipping contact response for new methods
  • Added methods to start and stop listening to shipping contact selections and update items/shipping methods in response to these selections
  • Updated completeLastTransaction to return a promise to be consistent with the cordova plugin
  • Updated examples

trueflywood's fork is currently used for this plugin. I'm changing it back to the original which contains the current changes and also includes type definitions and methods for the new version as well as documentation updates
@ihadeed ihadeed merged commit bf41506 into danielsogl:master Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants