fix(safari-view-controller): show should return an Observable

BREAKING CHANGE: `show` method now returns an Observable closes #1619
danielsogl · Jul 10, 2017 · a6f9714 · a6f9714
1 parent 7134965
commit a6f9714
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/@ionic-native/plugins/safari-view-controller/index.ts b/src/@ionic-native/plugins/safari-view-controller/index.ts
@@ -1,5 +1,6 @@
 import { Injectable } from '@angular/core';
 import { Cordova, Plugin, IonicNativePlugin } from '@ionic-native/core';
+import { Observable } from 'rxjs/Observable';
 
 export interface SafariViewControllerOptions {
   animated?: boolean;
@@ -74,13 +75,14 @@ export class SafariViewController extends IonicNativePlugin {
   /**
    * Shows Safari View Controller
    * @param options {SafariViewControllerOptions} optional
-   * @returns {Promise<any>}
+   * @returns {Observable<any>}
    */
   @Cordova({
     successIndex: 1,
-    errorIndex: 2
+    errorIndex: 2,
+    observable: true
   })
-  show(options?: SafariViewControllerOptions): Promise<any> { return; }
+  show(options?: SafariViewControllerOptions): Observable<any> { return; }
 
   /**
    * Hides Safari View Controller