-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari-view-controller : Only resolve one result #1619
Comments
Hey @tgensol, show: function (options, onSuccess, onError) {
options = options || {};
if (!options.hasOwnProperty('animated')) {
options.animated = true;
}
exec(onSuccess, onError, "SafariViewController", "show", [options]);
}, |
Hey @danielsogl , I know, and this is where the ionic-native plugin is not working as expected, https://ionicframework.com/docs/native/safari-view-controller/ The promise only resolved once (the result.opened), and then, it doesn't resolve again for "loaded" or closed. The doc is maybe wrong, or... ? |
Yeah, |
BREAKING CHANGE: `show` method now returns an Observable closes #1619
BREAKING CHANGE: `show` method now returns an Observable closes danielsogl#1619
I'm submitting a ... (check one with "x")
[X ] bug report
[ ] feature request
Current behavior:
The show function only returns one result.event (opened)
Expected behavior:
Maybe an Observable would to a better job than a promise ?
Related code:
The text was updated successfully, but these errors were encountered: