Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to use the new JPMS model and use Travis-ci to build & test against Java 9 & 11 #28

Closed
wants to merge 6 commits into from

Conversation

Warkdev
Copy link
Contributor

@Warkdev Warkdev commented Mar 27, 2019

Hi,

This is in reaction to the following issue: #27

- Use of the new JPMS system (since Java 9)
- Update of Classloader to match Java 9+ Classloader mechanism.
@Frotty
Copy link
Member

Frotty commented Mar 27, 2019

Hey, thanks for the PR 🍰
Looks good so far apart from the whitespace changes.
Please revert those ones in MpqTests.java. Then i can merge this.

Removal of definitely (wrong) whitespace characters.
@Warkdev
Copy link
Contributor Author

Warkdev commented Mar 27, 2019

Here you are, sorry for that, my IDE is introducing those, I must check why.

@Frotty
Copy link
Member

Frotty commented Mar 27, 2019

check here: https://github.com/inwc3/JMPQ3/pull/28/files#diff-59152c8afada68aad461481629115b78

Since there are only few changes, might be easier to revert completely.
We should probably add .editorconfig

Removing whitespace characters for try - catch statements.
@Warkdev
Copy link
Contributor Author

Warkdev commented Mar 27, 2019

Updated as well.

@Warkdev
Copy link
Contributor Author

Warkdev commented Mar 28, 2019

It obviously fails on oracle 8 and 9... Since I compiled on 11. I may lower this to jdk 9 but as the JPMS didn't exist in jdk8, it's a breaking point. Which trade-off would you prefer? I'll keep working with the modularized version anyway and will keep syncing your commits on my repo.

@Frotty
Copy link
Member

Frotty commented Mar 28, 2019

Probably just keep on a branch and merge when we move all projects to 11+

@Warkdev
Copy link
Contributor Author

Warkdev commented Mar 28, 2019

Good idea, I'll do that and do a proper commit + PR request again.

@Warkdev Warkdev closed this Mar 28, 2019
@Frotty
Copy link
Member

Frotty commented Mar 28, 2019

Alright, I created a java9-module branch https://github.com/inwc3/JMPQ3/tree/java9-module
You should open a new PR for that branch and I will merge.
You can then get the artifact from https://jitpack.io/#inwc3/jmpq3 by selecting the new branch from the dropdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants