Skip to content

Commit

Permalink
fix(app, ios): correct path to 'Info.plist' for ios build dependency (#…
Browse files Browse the repository at this point in the history
…5677)

The path used in the script is `_TARGET_PLIST="${BUILT_PRODUCTS_DIR}/${INFOPLIST_PATH}"`, but the path specified as "input files" was `$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)`. This caused that sometimes values from `firebase.json` were not taken into account on iOS, because build step "Processing Info.plist" could be executed after "[RNFB] Core Configuration" and it could overwrite the `Info.plist` file.

Related #5152 
Related #5153
  • Loading branch information
smikheiev committed Sep 2, 2021
1 parent ad361d2 commit ea6920c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/app/react-native.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = {
name: '[RNFB] Core Configuration',
path: './ios_config.sh',
execution_position: 'after_compile',
input_files: ['$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)'],
input_files: ['$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)'],
},
],
},
Expand Down

1 comment on commit ea6920c

@vercel
Copy link

@vercel vercel bot commented on ea6920c Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.