Skip to content

Commit

Permalink
fix(app-check, android): include all referenced dependencies correctly
Browse files Browse the repository at this point in the history
The debug provider is only used if the app is debuggable, and still requires
a token passed through somehow, so this doesn't increase security attack surface
area, but it does mean that release builds will have the symbol available which is
important
  • Loading branch information
mikehardy committed Aug 17, 2021
1 parent cac7be3 commit af336a3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/app-check/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ dependencies {
implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion('firebase', 'bom')}")
// These are beta, so they are not in the BoM yet. We have to specify the versions explicitly.
implementation 'com.google.firebase:firebase-appcheck-safetynet:16.0.0-beta02'
debugImplementation 'com.google.firebase:firebase-appcheck-debug:16.0.0-beta02'
implementation 'com.google.firebase:firebase-appcheck-debug:16.0.0-beta02'
}

ReactNative.shared.applyPackageVersion()
Expand Down

1 comment on commit af336a3

@vercel
Copy link

@vercel vercel bot commented on af336a3 Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.