Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move environment variable related strings into one class #648

Conversation

Pavel-Sulimau
Copy link
Contributor

Description

Extracted the duplicated and spread through different places environment keys into one class to have a more maintainable approach.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Feb 23, 2024

To view this pull requests documentation preview, visit the following URL:

melos.invertase.dev/~648

Documentation is deployed and generated using docs.page.

@Pavel-Sulimau Pavel-Sulimau marked this pull request as ready for review February 23, 2024 18:03
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor! Just one comment

@spydon spydon merged commit 2db32ec into invertase:main Feb 25, 2024
10 checks passed
@Pavel-Sulimau Pavel-Sulimau deleted the refactor/move-environment-variable-related-strings-into-one-class branch April 19, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants