Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate "melos exec" is not used in "run" along with "exec" #438

Merged

Conversation

BenVercammen
Copy link
Contributor

@BenVercammen BenVercammen commented Dec 22, 2022

Description

As described in #437, when using melos exec in scripts/*/run while also defining scripts/*/exec, an exception should be thrown as this would lead to melos exec being executed in every package.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

@blaugold blaugold changed the title fix: throw exception when using "melos exec" in "run" along with "exec" feat: throw exception when using "melos exec" in "run" along with "exec" Jan 3, 2023
@blaugold blaugold changed the title feat: throw exception when using "melos exec" in "run" along with "exec" feat: validate "melos exec" is not used in "run" along with "exec" Jan 3, 2023
@blaugold blaugold linked an issue Jan 3, 2023 that may be closed by this pull request
1 task
@blaugold
Copy link
Collaborator

blaugold commented Jan 3, 2023

@BenVercammen Thanks for the contribution! I refactored the validation to run when the options in melos.yaml are validated to give users this feedback as early as possible.

@blaugold blaugold merged commit 628f798 into invertase:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: scripts/*/exec/concurrency is acting unexpectedly
2 participants