Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melos Bootstrap overwrites all Intellij project config #333

Closed
1 task done
josh-burton opened this issue Jun 23, 2022 · 3 comments · Fixed by #351
Closed
1 task done

Melos Bootstrap overwrites all Intellij project config #333

josh-burton opened this issue Jun 23, 2022 · 3 comments · Fixed by #351
Assignees
Labels
bug Something isn't working

Comments

@josh-burton
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Version

2.5.0

Description

I regular run melos bootstrap to update the project if I have added new packages or new execs.

This seems to overwrite all Intellij config for the project. For example I exclude the .fvm/flutter_sdk folder from indexing, but each time I run bootstrap I need to redo this.

Do we need a way to run a partial bootstrap? Would it be possible not to overwrite the entire config?

Steps to reproduce

  1. Mark a folder in the IntelliJ project as excluded
  2. Run melos bootstrap
  3. The folder is now included again

Expected behavior

Some IntelliJ config should not be overwritten by bootstrap

Screenshots

No response

Additional context and comments

No response

@josh-burton josh-burton added bug Something isn't working Needs: Triage The issue needs triaging labels Jun 23, 2022
@blaugold
Copy link
Collaborator

ATM, we are overwriting the iml files for modules every time IntelliJ files are generated.

@Salakar Could we just write them if they don't already exist? The content always seems to be the same.

@blaugold blaugold removed the Needs: Triage The issue needs triaging label Jun 29, 2022
@Salakar
Copy link
Member

Salakar commented Jun 29, 2022

ATM, we are overwriting the iml files for modules every time IntelliJ files are generated.

@Salakar Could we just write them if they don't already exist? The content always seems to be the same.

This seems fine to me, only ones that should probably always write are the run configuration ones, all the project ones don't need to be rewritten everytime

@josh-burton
Copy link
Author

Might be nice to add an option(s) to the bootstrap command to do a full overwrite/wipe/nuke or just updating missing configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants