Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_notebooks.py to return only error list #372

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

gaugup
Copy link
Collaborator

@gaugup gaugup commented Jun 2, 2023

Looks like the notebook returned in not used.

Signed-off-by: Gaurav Gupta <47334368+gaugup@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Unit Test Results

286 tests  ±0   284 ✔️ ±0   7m 24s ⏱️ -41s
    1 suites ±0       2 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit fe674fe. ± Comparison against base commit ebb003e.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ebb003e) 68.27% compared to head (fe674fe) 68.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files          27       27           
  Lines        3603     3603           
=======================================
  Hits         2460     2460           
  Misses       1143     1143           
Flag Coverage Δ
unittests 68.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gaugup gaugup merged commit cf02a0b into main Jun 2, 2023
@gaugup gaugup deleted the gaugup/ReturnOnlyErrors branch June 2, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants