Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #303 - Reorder columns in query instance #304

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

lange-martin
Copy link
Contributor

Fixes #303 by reordering the columns of query_instance_df_dummies so that the resulting array has the same format as data_df_copy in the KD-tree.

Copy link
Collaborator

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @lange-martin . Looks good to me.

Signed-off-by: Martin Lange <ml_ks@web.de>
@lange-martin
Copy link
Contributor Author

lange-martin commented Jun 3, 2022

I updated the commit to include a Signed-off-by message.

@codecov-commenter
Copy link

Codecov Report

Merging #304 (5b6f5f2) into master (6b5a521) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   71.31%   71.42%   +0.10%     
==========================================
  Files          26       26              
  Lines        3462     3464       +2     
==========================================
+ Hits         2469     2474       +5     
+ Misses        993      990       -3     
Flag Coverage Δ
unittests 71.42% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dice_ml/explainer_interfaces/dice_KD.py 91.66% <100.00%> (+0.12%) ⬆️
dice_ml/explainer_interfaces/explainer_base.py 89.64% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5a521...5b6f5f2. Read the comment docs.

@amit-sharma amit-sharma merged commit 908f3e8 into interpretml:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DiCE with option "kd-tree" always generates the same counterfactuals for categorical data
3 participants