handle login forms with <input type="text"> fields in addition to use… #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rname (for this to work there must be exactly one input field whose name contains the string "username")
nlevitt
force-pushed
the
form-login-extra-inputs
branch
2 times, most recently
from
c51c3df
to
c1abbfa
Compare
* also fix new FormLoginProcessorTest.testFormLoginExtraInputs() in context of form-login-multipart changes * master: fix NullPointerException when using old HtmlFormCredential login to make this branch only about multipart/form-data, undo the changes to handle more complicated forms with extra input fields; add unit test; store CrawlURI submit data in http-library agnostic way and remove httpcomponents-specific code from HTMLForm, refactor creation of post data accordingly Be sure to return at least one of the candidates Remove unneeded constant Make sure to check form encoding type when addign form to curi data More changes for https://webarchive.jira.com/browse/ARI-4656 More changes Save enctype of form in submission curi Add ability to submit forms with enctype="multipart/form-data" If multiple username inputs in login form, favor the one with the word 'login' in it.
vonrosen
pushed a commit
that referenced
this pull request
Jan 19, 2016
handle login forms with <input type="text"> fields in addition to use…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rname (for this to work there must be exactly one input field whose name contains the string "username")