Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: rename object Deployment name #814

Closed
pohly opened this issue Nov 16, 2020 · 3 comments · Fixed by #843
Closed

operator: rename object Deployment name #814

pohly opened this issue Nov 16, 2020 · 3 comments · Fixed by #843
Assignees
@avalluri
Labels
0.9

Comments

@pohly
Copy link
Contributor

pohly commented Nov 16, 2020

The object name "Deployment" is the same as in core Kubernetes, which is confusing for users when talking about it and also isn't handled correctly by some software which only checks the object name without the API group (operator framework, vertical pod autoscaler).

We are still in alpha and can rename it in beta.

Possible replacements:

  • PMEMCSIDeployment
  • PmemCSIDeployment

In both cases, we need to support:

  • kubect get pmemcsideployments
@pohly
Copy link
Contributor Author

pohly commented Nov 16, 2020

I'm undecided about the spelling. PMEMCSIDeployment is consistent with how we spell the project, but doesn't look nice. PmemCSIDeployment is easier to read.

Thoughts?

@pohly pohly added the 0.9 label Dec 7, 2020
@pohly
Copy link
Contributor Author

pohly commented Dec 18, 2020

I suspect that renaming the object is a hard API break compared to 0.8.0. That's okay, we can remove v1alpha1 and replace it with a different object name in v1beta1.

@pohly pohly mentioned this issue Dec 18, 2020
Closed
5 tasks
@pohly
Copy link
Contributor Author

pohly commented Dec 22, 2020

On chat we agreed on PmemCSIDeployment.

avalluri added a commit to avalluri/pmem-CSI that referenced this issue Dec 29, 2020
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
fbd3a5b 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not it's sub types, becasue
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

This change is backward incompatible and we cannot support auto conversion of
existing v1alpha1 Deployment CRs.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Dec 29, 2020
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
8d7184f 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

This change is backward incompatible and we cannot support auto conversion of
existing v1alpha1 Deployment CRs.

FIXES intel#814
@avalluri avalluri mentioned this issue Dec 29, 2020
Merged
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 5, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
bc5410d 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 5, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
d0e499c 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 7, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
aa7e917 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 8, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
0a06382 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 8, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
e197c88 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 8, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
84030da 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 12, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
af359fd 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
avalluri added a commit to avalluri/pmem-CSI that referenced this issue Jan 12, 2021
@avalluri
operator: Rename deployment CRD name to pmemcsideployment
6a0c74b 
Renaming the operator `Deployment` API to `PmemCSIDeployment'. Prefixed
only the `Deployment` type with 'PmemCSI' not its sub-types, because
this is what used by the 'kubebuilder' to determine the generated CRD
Kind is.

FIXES intel#814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avalluri avalluri

Labels
0.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

operator: Rename Deployment -> PmemCSIDeployment avalluri/pmem-CSI
2 participants
@pohly @avalluri