Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][NFC] Fix formatting after handler member changes #14597

Conversation

steffenlarsen
Copy link
Contributor

#14460 appears to have introduced clang formatting violations, despite pre-commit not reporting these. This commit makes the formatting changes that should have been part of that patch.

intel#14460 appears to have introduced
clang formatting violations, despite pre-commit not reporting these.
This commit makes the formatting changes that should have been part of
that patch.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Copy link
Contributor

@hdelan hdelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we investigate why the clang format did not catch this in CI?

@steffenlarsen
Copy link
Contributor Author

LGTM. Should we investigate why the clang format did not catch this in CI?

It looks like there's something very wrong with the formatter job. #14600 passed out of the gate.

@steffenlarsen
Copy link
Contributor Author

Tag @aelovikov-intel for awareness.

@steffenlarsen
Copy link
Contributor Author

abi/sycl_classes_abi_neutral_test.cpp has been fixed separately.

@steffenlarsen steffenlarsen merged commit 0b60f43 into intel:sycl Jul 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants