-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Initial implementation of dynamic linking support in runtime #14587
Conversation
This patch provides an initial implementation for supporting the dynamic linking feature. Current known limitations are: lack of kernel bundle and AOT support.
@@ -521,6 +523,76 @@ static void emitBuiltProgramInfo(const pi_program &Prog, | |||
} | |||
} | |||
|
|||
static bool compatibleWithDevice(RTDeviceBinaryImage *BinImage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved with no changes.
Test failure is unrelated, should be fixed by #14589 |
@cperkinsintel gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small ask on the unit test, but LGTM
@sergey-semenov Seeing some postcommit failures: https://github.com/intel/llvm/actions/runs/10057852217/job/27802313127
and https://github.com/intel/llvm/actions/runs/10057852217/job/27799693475
|
Opened #14718 to address the warning |
The timeout appears to be flaky, couldn't reproduce it so far and the next post-commit passed. |
This patch provides an initial implementation for supporting the dynamic linking feature. Current known limitations are: lack of kernel bundle and AOT support.