Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Initial implementation of dynamic linking support in runtime #14587

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

sergey-semenov
Copy link
Contributor

This patch provides an initial implementation for supporting the dynamic linking feature. Current known limitations are: lack of kernel bundle and AOT support.

This patch provides an initial implementation for supporting
the dynamic linking feature. Current known limitations are:
lack of kernel bundle and AOT support.
@@ -521,6 +523,76 @@ static void emitBuiltProgramInfo(const pi_program &Prog,
}
}

static bool compatibleWithDevice(RTDeviceBinaryImage *BinImage,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved with no changes.

@sergey-semenov
Copy link
Contributor Author

Test failure is unrelated, should be fixed by #14589

@sergey-semenov
Copy link
Contributor Author

@cperkinsintel gentle ping

Copy link
Contributor

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small ask on the unit test, but LGTM

@sergey-semenov sergey-semenov merged commit 4bf1fe3 into intel:sycl Jul 23, 2024
15 checks passed
@sarnex
Copy link
Contributor

sarnex commented Jul 23, 2024

@sergey-semenov Seeing some postcommit failures:

https://github.com/intel/llvm/actions/runs/10057852217/job/27802313127

********************
Timed Out Tests (1):
  SYCL :: KernelAndProgram/test_cache_jit_aot.cpp

and

https://github.com/intel/llvm/actions/runs/10057852217/job/27799693475

 /__w/llvm/llvm/src/sycl/unittests/program_manager/DynamicLinking.cpp:67:20: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
   67 |                    std::move(createPropertySet(ExportedSymbols)));
      |                    ^
/__w/llvm/llvm/src/sycl/unittests/program_manager/DynamicLinking.cpp:67:20: note: remove std::move call here
   67 |                    std::move(createPropertySet(ExportedSymbols)));
      |                    ^~~~~~~~~~                                  ~
/__w/llvm/llvm/src/sycl/unittests/program_manager/DynamicLinking.cpp:70:20: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
   70 |                    std::move(createPropertySet(ImportedSymbols)));
      |                    ^
/__w/llvm/llvm/src/sycl/unittests/program_manager/DynamicLinking.cpp:70:20: note: remove std::move call here
   70 |                    std::move(createPropertySet(ImportedSymbols)));
      |                    ^~~~~~~~~~                                  ~

@sergey-semenov
Copy link
Contributor Author

Opened #14718 to address the warning

@sergey-semenov
Copy link
Contributor Author

The timeout appears to be flaky, couldn't reproduce it so far and the next post-commit passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants