-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add AMDGPU_kernel calling convention to detected kernels #14581
[SYCL] Add AMDGPU_kernel calling convention to detected kernels #14581
Conversation
Change looks good. Will it be reasonable to add a unit test for this? Thanks |
fcbfdec
to
bd49a51
Compare
bd49a51
to
7599fa9
Compare
7599fa9
to
df753f2
Compare
Sry for late, I updated that with a unittest |
df753f2
to
1995c50
Compare
1995c50
to
58f300c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYCL Changes LGTM!
@omarahmed1111, please, add [SYCL] tag to the PR title. |
@intel/llvm-gatekeepers Please merge when possible, Thanks! |
free_function_kernels.cpp
test had a bug where the kernels with demangled name for free functions will be deleted in thesycl-post-link
step of compilation. And this happened as AMD kernels was not detected due to a missing condition. This was not detected before as the HIP device on CI doesn't haveusm_shared_allocations
aspect available so it was detected as unsupported but when I tried it locally with a device withusm_shared_allocations
aspect available, the test was failing.