Connect support for dynamic linking to user options #14575

LU-JOHN · 2024-07-15T20:17:31Z

Add option "-fsycl-allow-device-dependencies" to enable support for dynamic linking.

Also:

No functions are importable without "-fsycl-allow-device-dependencies"
Deal with SYCL_EXTERNAL header decls that have lost SYCL_EXTERNAL attribute in LLVM IR
SPIRV/SYCL/ESIMD builtins cannot be an imported function

Tested in three E2E test cases.

Minor change:
Change SYCL-EXTERNAL to SYCL_EXTERNAL in testcase comment.

sarnex · 2024-07-15T20:25:06Z

clang/include/clang/Driver/Options.td

+def fsycl_allow_split_with_dependencies : Flag<["-"], "fsycl-allow-split-with-dependencies">,
+  Group<sycl_Group>, HelpText<"Allow dependencies between device code images">;
+def fno_sycl_allow_split_with_dependencies : Flag<["-"], "fno-sycl-allow-split-with-dependencies">,


I'm not sure if we need approval from the options group for these, @mdtoguchi?

@sarnex and @LU-JOHN, any new option (that we are inventing) that is meant to be visible should go through the options team workgroup.

Add new option in separate PR.

clang/lib/Driver/ToolChains/Clang.cpp

llvm/lib/SYCLLowerIR/ModuleSplitter.cpp

sarnex

lgtm only minor comments, the supportDynamicLinking function is a bit strange but i'm assuming this is an incremental change and it will be fleshed out soon, so it's fine with me

llvm/lib/SYCLLowerIR/ModuleSplitter.cpp

LU-JOHN · 2024-07-17T13:42:08Z

lgtm only minor comments, the supportDynamicLinking function is a bit strange but i'm assuming this is an incremental change and it will be fleshed out soon, so it's fine with me

Yes, this function can only return true with the -shared option when the SYCL RT is ready. Otherwise, "-shared" tests may start failing.

Signed-off-by: Lu, John <john.lu@intel.com>

…d for CUDA and hip Signed-off-by: Lu, John <john.lu@intel.com>

Signed-off-by: Lu, John <john.lu@intel.com>

…nking

AlexeySachkov · 2024-08-02T15:06:33Z

All builds have successfully completed after merge with sycl branch. Considering that we had a fully green CI run on the second to last commit and that changes this PR introduces are into a feature that is not supported on CUDA and HIP, I think that we can merge this PR sooner without waiting for CUDA & HIP CI jobs to complete.

I will proceed with merge, but @LU-JOHN, @maarquitos14, please keep an eye on unfinished jobs in case they highlight any unexpected failures.

Most likely the clang-format checker was down when #14575 ran CI, so a few changes non-clang-format-compliant made it in. Applying fixes to those. --------- Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>

LU-JOHN requested review from a team as code owners July 15, 2024 20:17

LU-JOHN had a problem deploying to WindowsCILock July 15, 2024 20:18 — with GitHub Actions Error

LU-JOHN had a problem deploying to WindowsCILock July 15, 2024 20:26 — with GitHub Actions Error

sarnex reviewed Jul 15, 2024

View reviewed changes

LU-JOHN had a problem deploying to WindowsCILock July 15, 2024 21:01 — with GitHub Actions Error

LU-JOHN temporarily deployed to WindowsCILock July 15, 2024 21:05 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock July 15, 2024 21:53 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock July 16, 2024 00:34 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock July 16, 2024 01:17 — with GitHub Actions Inactive

sarnex approved these changes Jul 16, 2024

View reviewed changes

llvm/lib/SYCLLowerIR/ModuleSplitter.cpp Outdated Show resolved Hide resolved

mdtoguchi approved these changes Jul 16, 2024

View reviewed changes

LU-JOHN force-pushed the more_dynamic_linking branch from 11e5bba to a903f6b Compare July 16, 2024 19:17

LU-JOHN temporarily deployed to WindowsCILock July 16, 2024 19:18 — with GitHub Actions Inactive

sarnex approved these changes Jul 16, 2024

View reviewed changes

LU-JOHN temporarily deployed to WindowsCILock July 16, 2024 21:12 — with GitHub Actions Inactive

LU-JOHN force-pushed the more_dynamic_linking branch from a903f6b to bc783e2 Compare July 17, 2024 13:34

LU-JOHN temporarily deployed to WindowsCILock July 17, 2024 13:35 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock July 17, 2024 15:38 — with GitHub Actions Inactive

LU-JOHN force-pushed the more_dynamic_linking branch from bc783e2 to 3e3318d Compare July 23, 2024 14:30

LU-JOHN temporarily deployed to WindowsCILock July 23, 2024 14:30 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock July 23, 2024 15:14 — with GitHub Actions Error

LU-JOHN temporarily deployed to WindowsCILock July 23, 2024 15:51 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock July 23, 2024 17:26 — with GitHub Actions Failure

LU-JOHN marked this pull request as draft July 24, 2024 03:38

LU-JOHN temporarily deployed to WindowsCILock July 24, 2024 04:00 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock July 24, 2024 04:43 — with GitHub Actions Error

LU-JOHN force-pushed the more_dynamic_linking branch from f247d50 to 4eae923 Compare July 24, 2024 04:46

LU-JOHN temporarily deployed to WindowsCILock July 24, 2024 04:47 — with GitHub Actions Inactive

LU-JOHN added 7 commits July 29, 2024 12:26

Test -fsycl-allow-device-dependencies with objects

3b8382b

Signed-off-by: Lu, John <john.lu@intel.com>

Use preferred header. Ensure host code cannot be used.

f884ad0

Signed-off-by: Lu, John <john.lu@intel.com>

-fPIC and -shared are Linux only. Device dependencies is not supporte…

7bd50b9

…d for CUDA and hip Signed-off-by: Lu, John <john.lu@intel.com>

Test -fsycl-allow-device-dependencies with a single DLL.

6e32667

Signed-off-by: Lu, John <john.lu@intel.com>

Do not test on cuda or hip

21d4be4

Signed-off-by: Lu, John <john.lu@intel.com>

Avoid failures on linux && gpu-intel-gen12 && opencl

f5fa46c

Signed-off-by: Lu, John <john.lu@intel.com>

Avoid failures on windows && gpu-intel-gen12 && level_zero

cfaaa42

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN force-pushed the more_dynamic_linking branch from 6ce91e5 to 54d50c4 Compare July 29, 2024 19:26

LU-JOHN had a problem deploying to WindowsCILock July 29, 2024 19:28 — with GitHub Actions Error

LU-JOHN force-pushed the more_dynamic_linking branch from 54d50c4 to cfaaa42 Compare July 29, 2024 20:51

LU-JOHN temporarily deployed to WindowsCILock July 29, 2024 20:52 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock July 29, 2024 23:32 — with GitHub Actions Inactive

sergey-semenov mentioned this pull request Jul 30, 2024

[SYCL] Fix dependency compilation after PI removal #14843

Merged

LU-JOHN added 2 commits July 30, 2024 08:26

Remove unsupported guards b/c of SYCL RT fix

2df4193

Signed-off-by: Lu, John <john.lu@intel.com>

SYCL RT fix from Sergey Semenov

46a75e3

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN temporarily deployed to WindowsCILock July 30, 2024 15:39 — with GitHub Actions Inactive

LU-JOHN had a problem deploying to WindowsCILock July 30, 2024 17:57 — with GitHub Actions Error

Restore Windows UNSUPPORTED guard

cf2b52b

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN temporarily deployed to WindowsCILock July 30, 2024 20:51 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock July 30, 2024 23:53 — with GitHub Actions Inactive

Fix Windows failure by adding dll suffix

2388a77

Signed-off-by: Lu, John <john.lu@intel.com>

LU-JOHN temporarily deployed to WindowsCILock July 31, 2024 14:53 — with GitHub Actions Inactive

LU-JOHN temporarily deployed to WindowsCILock July 31, 2024 16:11 — with GitHub Actions Inactive

Merge remote-tracking branch 'intel/origin/sycl' into more_dynamic_li…

0464e67

…nking

maarquitos14 temporarily deployed to WindowsCILock August 1, 2024 09:47 — with GitHub Actions Inactive

maarquitos14 temporarily deployed to WindowsCILock August 1, 2024 10:35 — with GitHub Actions Inactive

AlexeySachkov merged commit 3c0532d into intel:sycl Aug 2, 2024
12 of 14 checks passed

maarquitos14 mentioned this pull request Aug 5, 2024

[NFC] Clang-format fixes. #14946

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connect support for dynamic linking to user options #14575

Connect support for dynamic linking to user options #14575

LU-JOHN commented Jul 15, 2024 •

edited

Loading

sarnex Jul 15, 2024

mdtoguchi Jul 15, 2024

LU-JOHN Jul 16, 2024

sarnex left a comment

LU-JOHN commented Jul 17, 2024

AlexeySachkov commented Aug 2, 2024

Connect support for dynamic linking to user options #14575

Connect support for dynamic linking to user options #14575

Conversation

LU-JOHN commented Jul 15, 2024 • edited Loading

sarnex Jul 15, 2024

Choose a reason for hiding this comment

mdtoguchi Jul 15, 2024

Choose a reason for hiding this comment

LU-JOHN Jul 16, 2024

Choose a reason for hiding this comment

sarnex left a comment

Choose a reason for hiding this comment

LU-JOHN commented Jul 17, 2024

AlexeySachkov commented Aug 2, 2024

LU-JOHN commented Jul 15, 2024 •

edited

Loading