-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][HIP] Add AMDGPU reflect pass to choose between safe and unsafe AMDGPU atomics #11467
Merged
Commits on Apr 22, 2024
-
Add AMDGPU reflect pass for atomic xor
AMDGPU reflect pass is needed to choose between safe and unsafe atomics at the libclc level. In the long run we will delete this patch as work is being done to ensure correct lowering of atomic instructions. See patches: llvm/llvm-project#85052 llvm/llvm-project#69229 This work is necessary as malloc shared atomics rely on PCIe atomics which can have patchy and unreliable support. We want to therefore be able to choose at compile time whether we should use safe atomics using CAS (which PCIe should support), or if we want to rely of the availability of the newest PCIe atomics, if malloc shared atomics are desired. Also changes the implementation of Or, And so that they can choose between the safe or unsafe version based on the AMDGPU reflect value.
Configuration menu - View commit details
-
Copy full SHA for 759382e - Browse repository at this point
Copy the full SHA 759382eView commit details -
Add SYCL test and fix filename in header
Add a test to make sure that the correct safe/unsafe int atomics are being generated from SYCL tomic ref member functions.
Configuration menu - View commit details
-
Copy full SHA for 917704e - Browse repository at this point
Copy the full SHA 917704eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e27d85 - Browse repository at this point
Copy the full SHA 7e27d85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7310737 - Browse repository at this point
Copy the full SHA 7310737View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8194079 - Browse repository at this point
Copy the full SHA 8194079View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d17f4f - Browse repository at this point
Copy the full SHA 4d17f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f2771b - Browse repository at this point
Copy the full SHA 7f2771bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 695fcfa - Browse repository at this point
Copy the full SHA 695fcfaView commit details -
- Change getNumOperands to arg size - Move size check above the for loop
Configuration menu - View commit details
-
Copy full SHA for 6d24772 - Browse repository at this point
Copy the full SHA 6d24772View commit details
Commits on Apr 23, 2024
-
- Use a vector of CallInsts instead of Instructions. - Change assert(fasle) to report_fatal_error.
Configuration menu - View commit details
-
Copy full SHA for 8eedac8 - Browse repository at this point
Copy the full SHA 8eedac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4ab1ed - Browse repository at this point
Copy the full SHA c4ab1edView commit details
Commits on Apr 24, 2024
-
- Use auto - Use drop_back to remove null byte - Replace hip_be with hip
Configuration menu - View commit details
-
Copy full SHA for bf5d2d0 - Browse repository at this point
Copy the full SHA bf5d2d0View commit details -
Change opt test to use update_test_checks.py
Configuration menu - View commit details
-
Copy full SHA for bbce2f9 - Browse repository at this point
Copy the full SHA bbce2f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a8e706 - Browse repository at this point
Copy the full SHA 1a8e706View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.