Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][HIP] Add AMDGPU reflect pass to choose between safe and unsafe AMDGPU atomics #11467

Merged
merged 14 commits into from
Apr 24, 2024

Commits on Apr 22, 2024

  1. Add AMDGPU reflect pass for atomic xor

    AMDGPU reflect pass is needed to choose between safe and unsafe atomics
    at the libclc level. In the long run we will delete this patch as work
    is being done to ensure correct lowering of atomic instructions. See
    patches:
    
    llvm/llvm-project#85052
    llvm/llvm-project#69229
    
    This work is necessary as malloc shared atomics rely on PCIe atomics
    which can have patchy and unreliable support. We want to therefore be
    able to choose at compile time whether we should use safe atomics using
    CAS (which PCIe should support), or if we want to rely of the
    availability of the newest PCIe atomics, if malloc shared atomics are
    desired.
    
    Also changes the implementation of Or, And so that they can choose
    between the safe or unsafe version based on the AMDGPU reflect value.
    hdelan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    759382e View commit details
    Browse the repository at this point in the history
  2. Add SYCL test and fix filename in header

    Add a test to make sure that the correct safe/unsafe int atomics are
    being generated from SYCL tomic ref member functions.
    hdelan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    917704e View commit details
    Browse the repository at this point in the history
  3. List passname alphabetically

    hdelan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7e27d85 View commit details
    Browse the repository at this point in the history
  4. Remove blankline

    hdelan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7310737 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8194079 View commit details
    Browse the repository at this point in the history
  6. Typo

    hdelan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4d17f4f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7f2771b View commit details
    Browse the repository at this point in the history
  8. Restructure comment

    hdelan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    695fcfa View commit details
    Browse the repository at this point in the history
  9. Respond to comments

    - Change getNumOperands to arg size
    - Move size check above the for loop
    hdelan committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6d24772 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Respond to comments

    - Use a vector of CallInsts instead of Instructions.
    - Change assert(fasle) to report_fatal_error.
    hdelan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8eedac8 View commit details
    Browse the repository at this point in the history
  2. Typo

    hdelan committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c4ab1ed View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Respond to comments

    - Use auto
    - Use drop_back to remove null byte
    - Replace hip_be with hip
    hdelan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    bf5d2d0 View commit details
    Browse the repository at this point in the history
  2. Use update_test_checks.py

    Change opt test to use update_test_checks.py
    hdelan committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    bbce2f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1a8e706 View commit details
    Browse the repository at this point in the history