-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak #224
Fix memory leak #224
Conversation
Let me test this first
…On Mon, May 22, 2023, 6:29 AM Adam Eisenreich ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#224
Commit Summary
- ce84bf5
<ce84bf5>
Fix: Memory leak on every change of source
File Changes
(1 file <https://github.com/intbot/ng2-pdfjs-viewer/pull/224/files>)
- *M* lib/src/ng2-pdfjs-viewer.component.ts
<https://github.com/intbot/ng2-pdfjs-viewer/pull/224/files#diff-29c27c9eab17983a95c97e2684e13c13be4fc827f04d33e0e5d65c65fedc8774>
(22)
Patch Links:
- https://github.com/intbot/ng2-pdfjs-viewer/pull/224.patch
- https://github.com/intbot/ng2-pdfjs-viewer/pull/224.diff
—
Reply to this email directly, view it on GitHub
<#224>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEL3UNRCCXUHDFMTYPDQLO3XHM5Z7ANCNFSM6AAAAAAYKHOTIA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Just rebased. This fixes the |
@Akxe, You are super quick. Appreciate it. Merging |
Looks like there is still a leak when the component is destroyed, right? |
This PR fixed one. Did you find any other? |
I just noticed that the added |
Well... It must have gotten removed when rebasing the PR on the new master... I am out of the office. Would you create the mentioned fix? |
No description provided.