Skip to content

Commit

Permalink
Initial thoughts on 4.x upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
codehippie1 committed May 30, 2024
1 parent 9b63e56 commit 8fdead2
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions lib/Pdfjs.4.x.upgrade.MD
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Let's leave sample app for now. It is easy to rewrite from scratch.
Let's leave live demo as well. Plan is to rewrite.

- Why was ng-packagr added as dev dependency ?
- Assuming shx works on windows as well. New to this.
- PDF's are loaded inside an iframe. Does document.addEventListner() gets fired even if we use iframe?
There are two scenarios. PDF can be embedded in html or opened in a new window.
- I like the way pdfjs's event bus is used. In the beginning I had to hack pdfjs library pdfjs library to send those browser events. :-)



Thought for community - How about starting a discord server for ng2-pdfjs-viewer ?


0 comments on commit 8fdead2

Please sign in to comment.