Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigstore/gh-action-sigstore-python from 2.1.1 to 3.0.0 #139

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 16, 2024

Bumps sigstore/gh-action-sigstore-python from 2.1.1 to 3.0.0.

Release notes

Sourced from sigstore/gh-action-sigstore-python's releases.

v3.0.0

Added

  • inputs now allows recursive globbing with ** (#106)

Removed

  • The following settings have been removed: fulcio-url, rekor-url, ctfe, rekor-root-pubkey (#140)
  • The following output settings have been removed: signature, certificate, bundle (#146)

Changed

  • inputs is now parsed according to POSIX shell lexing rules, improving the action's consistency when used with filenames containing whitespace or other significant characters (#104)

  • inputs is now optional if release-signing-artifacts is true and the action's event is a release event. In this case, the action takes no explicit inputs, but signs the source archives already attached to the associated release (#110)

  • The default suffix has changed from .sigstore to .sigstore.json, per Sigstore's client specification (#140)

  • release-signing-artifacts now defaults to true (#142)

Fixed

  • The release-signing-artifacts setting no longer causes a hard error when used under the incorrect event (#103)

  • Various deprecations present in sigstore-python's 2.x series have been resolved (#140)

  • This workflow now supports CI runners that use PEP 668 to constrain global package prefixes (#145)

... (truncated)

Changelog

Sourced from sigstore/gh-action-sigstore-python's changelog.

Changelog

All notable changes to gh-action-sigstore-python will be documented in this file.

The format is based on Keep a Changelog.

All versions prior to 3.0.0 are untracked.

[Unreleased]

[3.0.0]

Added

  • inputs now allows recursive globbing with ** (#106)

Removed

  • The following settings have been removed: fulcio-url, rekor-url, ctfe, rekor-root-pubkey (#140)
  • The following output settings have been removed: signature, certificate, bundle (#146)

Changed

  • inputs is now parsed according to POSIX shell lexing rules, improving the action's consistency when used with filenames containing whitespace or other significant characters (#104)

  • inputs is now optional if release-signing-artifacts is true and the action's event is a release event. In this case, the action takes no explicit inputs, but signs the source archives already attached to the associated release (#110)

  • The default suffix has changed from .sigstore to .sigstore.json, per Sigstore's client specification (#140)

  • release-signing-artifacts now defaults to true (#142)

Fixed

  • The release-signing-artifacts setting no longer causes a hard error

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [sigstore/gh-action-sigstore-python](https://github.com/sigstore/gh-action-sigstore-python) from 2.1.1 to 3.0.0.
- [Release notes](https://github.com/sigstore/gh-action-sigstore-python/releases)
- [Changelog](https://github.com/sigstore/gh-action-sigstore-python/blob/main/CHANGELOG.md)
- [Commits](sigstore/gh-action-sigstore-python@61f6a50...f514d46)

---
updated-dependencies:
- dependency-name: sigstore/gh-action-sigstore-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Jul 16, 2024
@russellb
Copy link
Member

note that I think there's at least one minor workflow change needed before merging this. our workflow removes the signature file assuming the old filename based on my reading of the 3.0.0 release notes

@bjhargrave
Copy link

This also needs adding release-signing-artifacts: false to the sigstore action config to prevent the action from performing a GitHub release.

@mergify mergify bot added the CI/CD Affects CI/CD configuration label Aug 28, 2024
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg
Copy link
Member

@instructlab/training-maintainers I've updated this PR to a state it should be good for approval for - see instructlab/eval#76 as a reference

Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot added the one-approval label Oct 7, 2024
Copy link
Contributor

@Maxusmusti Maxusmusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 28e6982 into main Oct 7, 2024
6 checks passed
@mergify mergify bot removed the one-approval label Oct 7, 2024
@dependabot dependabot bot deleted the dependabot/github_actions/sigstore/gh-action-sigstore-python-3.0.0 branch October 7, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants