Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!!ASAP!!! 0.15.1 crash native apps!!! #150

Closed
oxyii opened this issue Mar 3, 2019 · 9 comments
Closed

!!!ASAP!!! 0.15.1 crash native apps!!! #150

oxyii opened this issue Mar 3, 2019 · 9 comments

Comments

@oxyii
Copy link
Contributor

oxyii commented Mar 3, 2019

overflowY crash app just importing MenuProvider !!!

@jamesvweston
Copy link

Related to this issue: #146

@jamesvweston
Copy link

For a temporary fix replace "^0.15.0" with "0.15.0" in package.json

@oxyii
Copy link
Contributor Author

oxyii commented Mar 3, 2019

I know, thanks. Issue created for repo-members )

npm install --save react-native-popup-menu@0.15.0 works fine too

@sodik82 sodik82 closed this as completed in c72a8c7 Mar 3, 2019
@sodik82
Copy link
Contributor

sodik82 commented Mar 3, 2019

Thanks for letting us know... Funny thing that 0.15.1 is working fine in expo ( https://snack.expo.io/@sodik82/react-native-popup-menu-with-trigger-long-press ) but overflowY seems not to be official property in RN. Fixed in 0.15.2

@sodik82
Copy link
Contributor

sodik82 commented Mar 3, 2019

@oxyii is 0.15.2 fine?

@oxyii
Copy link
Contributor Author

oxyii commented Mar 3, 2019

@sodik82 Yep, 0.15.2 works fine on native platforms. But have useNativeDriver warning on web when menu open

_001

@oxyii
Copy link
Contributor Author

oxyii commented Mar 3, 2019

@sodik82 I think in build folder must be 3 files

  • index.js // <- just export from "react-native-popup-menu"
  • react-native-popup-menu.js // <- for native platforms
  • react-native-popup-menu.web.js // <- for web

or do not build at all.

Metro bundler will compile her-self.
Developers who works with web platform already made an ejection and added required node_modules libraries into babel config. Impossible to create a good RNWeb app without ejecting or using others libs for babel configuration like a react-app-rewired and customize-cra. IMHO )

@sodik82
Copy link
Contributor

sodik82 commented Mar 3, 2019

The build for RNWeb came from community. However I like your idea - two builds could use different env variables to enable/disable native driver.

Could you create something like that? Or at least create new improvement issue :)

@oxyii
Copy link
Contributor Author

oxyii commented Mar 3, 2019

Platform-specific code works fine natively. Just create *.<platform>.js )) *.web.js too. You do not need to do something else.

I don't have enough time to do that now but I just fixed web warning. See PR

TheAlmightyBob pushed a commit to TheAlmightyBob/react-native-popup-menu that referenced this issue Feb 12, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants