feat: deprecate Connect4 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
clement-bonnet
commented
Feb 15, 2023
•
clement-bonnet
commented
- deprecate Connect4 by throwing a warning
- fix Connect4 action mask type
- downgrade pygame to support python 3.7
clement-bonnet
added
documentation
dluo96
reviewed
Feb 15, 2023
dluo96
reviewed
Feb 15, 2023
djbyrne
previously approved these changes
Feb 15, 2023
djbyrne
approved these changes
Feb 16, 2023
Closed
wang-r-j
added a commit
to wang-r-j/jumanji
that referenced
this pull request
Mar 10, 2023
The pygame compatibility bugs with python 3.7 were first introduced in pygame 2.1.3.dev6 (pygame/pygame@a462721e) and were fully resolved in 2.2.0.dev2 (pygame/pygame#3723, pygame/pygame#3722, pygame/pygame@aab517c7). So we can relax the requirement tightened in instadeepai#67 (instadeepai/jumanji#7dcd89f8) and just exlude 2.1.3.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.