Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate Connect4 #66

Closed
clement-bonnet opened this issue Jan 30, 2023 · 1 comment
Closed

feat: deprecate Connect4 #66

clement-bonnet opened this issue Jan 30, 2023 · 1 comment
Assignees
@clement-bonnet
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@clement-bonnet
Copy link
Collaborator

clement-bonnet commented Jan 30, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe

Connect4 will be removed in a future release (v0.2).

Describe the solution you'd like

Raise a deprecated warning when using Connect4 as it will be removed soon.

Remark

Bug in the reset function: action_mask = jnp.ones((BOARD_WIDTH,), dtype=jnp.int8) should be changed to action_mask = jnp.ones((BOARD_WIDTH,), dtype=bool).
@clement-bonnet clement-bonnet added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 30, 2023
@clement-bonnet
Copy link
Collaborator Author

Fixed in #67

@clement-bonnet clement-bonnet self-assigned this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clement-bonnet clement-bonnet

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clement-bonnet