-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(roboticWarehouse): goal conditional #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some grammar and some really minor changes
Co-authored-by: Sasha <reallysasha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Would it be possible to start a few steps of a2c training (with default params) and seed either 1, 2 or 3 to make sure the behavior is fixed?
…/jumanji into 190-fix-rware-reward
We ran some experiments to confirm, everything works as expected now. In essence, the problem remained the same but with inverted goal positions which caused a mismatch between the rendering. In the runs we did, the agents trained and the rendering looked good. I will also add an updated gif to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes! 🚀
…0-fix-rware-reward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you @arnupretorius 🔥
Fix the goal conditional for reward in robotic warehouse.
Closes #190