Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pacman environment #186

Merged
merged 138 commits into from
Jan 29, 2024
Merged

feat: pacman environment #186

merged 138 commits into from
Jan 29, 2024

Conversation

siddarthsingh1
Copy link
Contributor

Full Pacman environment code, including random/a2c agents and documentation.

closes #182

clement-bonnet
clement-bonnet previously approved these changes Jan 29, 2024
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!
You just need to:

  • Add your environment to the API docs (see how it is done in the Sokoban PR)
  • Add pac_man to the mkdocs file (see the Sokoban PR)

docs/environments/pacman.md Outdated Show resolved Hide resolved
jumanji/training/configs/config.yaml Outdated Show resolved Hide resolved
jumanji/training/configs/config.yaml Outdated Show resolved Hide resolved
siddarthsingh1 and others added 5 commits January 29, 2024 11:36
update names

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
update configs

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clement-bonnet clement-bonnet merged commit 0ba80dc into instadeepai:main Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pacman environment
6 participants