Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cvrp): generator #138

Merged
merged 7 commits into from
May 26, 2023
Merged

feat(cvrp): generator #138

merged 7 commits into from
May 26, 2023

Conversation

surana01
Copy link
Contributor

@surana01 surana01 commented May 18, 2023

Implement a Generator class for the CVRP environment which is responsible for generating the CVRP instances. This will include the following additions:

  • A generator.py script added to the cvrp folder which implements an abstract class Generator and a RandomGenerator to create a random uniform CVRP instance.
  • A generator_test.py script to test the generator.
  • Modifications to env.py to include the generator in the init method and changes to conftest.py to include a DummyGenerator for testing purposes.

@surana01 surana01 added the enhancement New feature or request label May 18, 2023
@surana01 surana01 self-assigned this May 18, 2023
clement-bonnet
clement-bonnet previously approved these changes May 19, 2023
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost perfect, thanks!

jumanji/environments/routing/cvrp/env.py Outdated Show resolved Hide resolved
clement-bonnet
clement-bonnet previously approved these changes May 26, 2023
Copy link
Collaborator

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
@surana01 surana01 merged commit 931614b into instadeepai:main May 26, 2023
@surana01 surana01 deleted the cvrp-generator branch May 26, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants