Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/MAPPO Obs Networks Fix + Multiple Optims #454

Merged
merged 15 commits into from
Mar 23, 2022

Conversation

KaleabTessera
Copy link
Contributor

@KaleabTessera KaleabTessera commented Mar 15, 2022

What?

  • Fixed observation network bug in mappo - observations were being transformed outside of tf.GradientTape.
  • Set mappo to use two optims for better performance and consistency with other mappo implementations.

Why?

Improve mappo performance.

How?

Extra

Address #419 for mappo.
Closes #455 .

Copy link
Contributor

@DriesSmit DriesSmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work @KaleabTessera and @AsadJeewa 😄 🔥

@AsadJeewa AsadJeewa self-requested a review March 23, 2022 09:38
@KaleabTessera KaleabTessera merged commit 1021b3f into develop Mar 23, 2022
@KaleabTessera KaleabTessera deleted the feat/single-vs-multiple-optim branch March 23, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Inconsistent Mypy behaviour
3 participants