Feature/jax abstract system class #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnupretorius
requested review from
KaleabTessera,
DriesSmit,
mmorris44,
AsadJeewa,
RuanJohn and
jcformanek
as code owners
|
Really glad that we are finally adding a base class for systems. |
AsadJeewa
reviewed
Feb 17, 2022
AsadJeewa
previously approved these changes
Feb 22, 2022
RuanJohn
reviewed
Feb 24, 2022
AsadJeewa
previously approved these changes
Feb 24, 2022
RuanJohn
approved these changes
Feb 25, 2022
KaleabTessera
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Abstract system class for new build system for jax agents.
Why?
Create an interface for systems with functions supporting component-wise builds.
How?
Created a new base abstract class for systems.
Extra
Regarding tests, please note that so far I'm following a different approach than what we had previously been following, which is to locate test files alongside feature files. Two reasons for this: (1) to separate it from our TF2 tests and (2) to experiment whether this might be a more preferred method. But happy to chat more about this.
closes #404