chore: add optional benchmark questions to feature

[arnupretorius]

What?

Add benchmarking questions to feature template.

Why?

Remove the need to separate issue. Use benchmark issue template for planning/larger-scale benchmarking.

[RuanJohn]

Aside from just how and why, I think we need to also ask that any relevant parameter configurations to be used for benchmarking should be included.

[AsadJeewa]

How do we expect to use this, since it is optional? We would often create simple issues without adding benchmark info so is this for "big" changes?

[KaleabTessera]

Aside from just how and why, I think we need to also ask that any relevant parameter configurations to be used for benchmarking should be included.

I guess the real question for this is whether to make the benchmarking results public. We can always link to our internal results - which contains config etc, they just won't be available to the public.

I think in the beginning it is fine if we keep the benchmarks private (might a bit of admin to share the public results for every PR).

[arnupretorius]

Aside from just how and why, I think we need to also ask that any relevant parameter configurations to be used for benchmarking should be included.

I guess the real question for this is whether to make the benchmarking results public. We can always link to our internal results - which contains config etc, they just won't be available to the public.

I think in the beginning it is fine if we keep the benchmarks private (might a bit of admin to share the public results for every PR).

Yes, I agree, I don't think we have to share for each PR. But what I think we can do is place the latest benchmark results somewhere on the Repo and update them as we go along.