-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/Updates for new acme version. #308
Conversation
…ntially." This reverts commit 0bc13ba.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @KaleabTessera 🔥
@@ -111,8 +111,7 @@ def __init__( | |||
max_in_flight_items=max_in_flight_items, | |||
delta_encoded=delta_encoded, | |||
priority_fns=priority_fns, | |||
# TODO(Kale-ab) Re-add this when using newer version of acme. | |||
# get_signature_timeout_ms=get_signature_timeout_ms | |||
get_signature_timeout_ms=get_signature_timeout_ms, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KaleabTessera!! 🙌
What?
Updates for
dm-acme
version 0.2.2.Why?
How?
Extra