Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/upgrade acme version and use new adders #274

Merged
merged 31 commits into from
Jul 20, 2021
Merged

Feature/upgrade acme version and use new adders #274

merged 31 commits into from
Jul 20, 2021

Conversation

KaleabTessera
Copy link
Contributor

What?

  • Upgraded acme adders and wrote tests.
  • Enforced docstring styles.
  • Wrote tests for all systems.

Why?

  • To use new version of acme.

How?

  • Updated adders.

Extra

@DriesSmit I will need to make minor updates to the system tests once your network keys PR is in.

DriesSmit and others added 30 commits July 7, 2021 16:01
@DriesSmit
feature: Update Acme and Reverb version n setup.py.
883e154
@DriesSmit
fix: Start upgrading transition adders.
ef29a92
@DriesSmit
Fix bugs.
a3884f9
@DriesSmit
feature: Update sequence adder. It is now running using the latest re…
b9dbf53 
…verb and acme setup.
@KaleabTessera
chore: Made openspiel a non mandatory install.
df83c35
@DriesSmit
fix: Fix mypy issues.
6d5975a
@DriesSmit
fix: Small fix the the sequence adder.
9092e7c
@DriesSmit
feature: Add use_next_extras.
1194723
@DriesSmit
fix: Small update to PPO.
7170d65
@jcformanek
fix: use acme function to make the dataset in MAPPO.
975453e
@KaleabTessera
Auto stash before merge of "feature/upgrade-acme-version" and "origin…
3b8c378 
…/feature/upgrade-acme-version"
@KaleabTessera
chore: Updated doc strings for base add method.
17efb1a
@KaleabTessera
fix: Fixed signature for transition adder.
f67c41b
@KaleabTessera
feat: Allowed specs to be directly passed into ma env specs.
54ad3fe
@KaleabTessera
feat(tests): Added utility class to test adders.
db4b262
@KaleabTessera
tests(adders): Tested transition adder, with nstep=1.
019be39
@KaleabTessera
chore: Safely import deprecated acme module.
ba7b5a2
@KaleabTessera
tests(adders): Transition adder tests, with n_step>1.
1bfdfc2
@KaleabTessera
tests(adders): Final transition adder tests.
19e2617
@KaleabTessera
tests(adders): Wrote seq adder tests.
4782c52
@KaleabTessera
fix(adders): Get priority fns working again.
35d6cc4
@KaleabTessera
feat(adders): Updated episode adder and wrote tests.
e6cd902
@KaleabTessera
chore(adders): Cleaned up adders.
20599fa
@KaleabTessera
chore: Updated test.sh.
a058eb4
@KaleabTessera
chore: Updated the defaults for dial.
85a6969
@KaleabTessera
chore: Updated training to use new replay data format.
d428f4b
@KaleabTessera
tests(systems): Added more system tests and added some recurrent tests.
db94ea3
@KaleabTessera
tests(systems): Updated system tests.
a88d492
@KaleabTessera
feat(docstring): Added pre-commits for formatted docstrings.
949a152
@KaleabTessera
chore: Added pydocstyle to setup.py.
5c5cd2b
@arnupretorius arnupretorius added the enhancement New feature or request label Jul 19, 2021
@arnupretorius arnupretorius merged commit fae87ce into develop Jul 20, 2021
@arnupretorius arnupretorius deleted the feature/upgrade-acme-version branch July 20, 2021 12:09
@KaleabTessera KaleabTessera restored the feature/upgrade-acme-version branch July 20, 2021 12:14
@arnupretorius arnupretorius deleted the feature/upgrade-acme-version branch February 21, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnupretorius arnupretorius Awaiting requested review from arnupretorius arnupretorius is a code owner

@DriesSmit DriesSmit Awaiting requested review from DriesSmit DriesSmit is a code owner

Assignees

@KaleabTessera KaleabTessera

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KaleabTessera @arnupretorius @DriesSmit @jcformanek