Chore/Updated makefile and readme for Windows. #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop into main.
Hotfix/Merge develop into main.
Release 0.1.0
## What? [Updated makefile and readme] ## Why? [Easier installation for Windows] ## How? [] ## Extra []
KaleabTessera
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Congrats on your first PR @Nashlen 🥳 👐
This still worked on my side. Just a minor comment on the string in the readme.
README.md
Outdated
| @@ -159,6 +159,10 @@ We have tested `mava` on Python 3.6, 3.7 and 3.8. | |||
| ```bash | |||
| make build | |||
| ``` | |||
| For Windows, before the docker image build, we recommend to first install the package manager [chocolatey](https://chocolatey.org/install) and run: | |||
There was a problem hiding this comment.
I would make this a little clearer. ...install the package manager [chocolatey](https://chocolatey.org/install) and run [to install make]:
Updated readme to make it a little clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updated makefile and readme.
Why?
Easier installation for Windows.
How?
Extra