Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct typo in the comment for los_az_angle to orb_az_angle conversion #978

Merged
merged 1 commit into from
Mar 14, 2023
Merged

correct typo in the comment for los_az_angle to orb_az_angle conversion #978

merged 1 commit into from
Mar 14, 2023

Conversation

bjmarfito
Copy link
Contributor

@bjmarfito bjmarfito commented Mar 14, 2023 •
edited by yunjunz
Loading

…ngle

Description of proposed changes

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)

yunjunz
yunjunz approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it's a typo in the comment, the calculation in the code is correct. Thanks for catching this!

@yunjunz yunjunz changed the title Make some changes in the comments related to calculation of orb_az_a… correct typo in the comment for los_az_angle to orb_az_angle conversion Mar 14, 2023
@yunjunz yunjunz merged commit 7704c34 into main Mar 14, 2023
@bjmarfito bjmarfito deleted the bjmarfito-patch-1 branch March 14, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunjunz yunjunz yunjunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjmarfito @yunjunz