Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multilook: support GDAL VRT file #959

Merged
merged 2 commits into from
Feb 14, 2023
Merged

multilook: support GDAL VRT file #959

merged 2 commits into from
Feb 14, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Feb 14, 2023

Description of proposed changes

  • multilook.py:

    • add multilook_gdal() to generate the multilooked lat/lon.rdr files from isce-generated GDAL VRT files (lat/lon.rdr.full.vrt) directly; add example usage in cli.multilook.py.
    • remove the obsolete multilook_matrix() and add its core part as commented code block within multilook_data().
    • multilook_data(): apply cropping of the input data for all methods, as a generic preparation step, to simplify the code laterward.
  • utils.readfile.py:

    • read_attribute(): ignore '.mli' for FILE_TYPE, similar to '.full' and '.rdr' in the path
    • get_slice_list(): support dense offsets generated by isce2/topsApp.py, to facilitate the auto reading of read()

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ multilook.py:
   - add multilook_gdal() to support GDAL VRT file as input, in order to generate multilooked lat/lon.rdr file from isce-2 generated lat/lon.rdr.full.vrt file directly

+ cli.multilook.py: add example usage

+ utils.readfile.py:
   - read_attribute(): ignore '.mli' for FILE_TYPE, similar to '.full' and '.rdr' in the path
   - get_slice_list(): support dense offsets generated by isce2/topsApp.py, to facilitate the auto reading of read()
+ remove the obsolete `multilook_matrix()` and add its core part as commented code block within `multilook_data()`

+ apply croping of the input data for all methods, as a generic preparation step, to simplify the code laterward
@yunjunz yunjunz merged commit 9e979e0 into insarlab:main Feb 14, 2023
@yunjunz yunjunz deleted the multilook branch February 14, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant