Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ts)view: auto-adjust lat/lon decimal places + ignore ex date for time func fit #942

Merged
merged 4 commits into from
Dec 31, 2022

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Dec 30, 2022

Description of proposed changes

  • utils.utils0.py: add get_lalo_digit4display() to calculate the appropriate decimal places for the lat/lon coordinates for displaying purposes, based on the pixel size info in the metadata.

    • view.plot_slice(): call ut.get_lalo_digit4display() and use it in format_coord() for the status bar.
    • tsview: call ut.get_lalo_digit4display() in read_init_info() and use it in get_point_coord_str() for the figure title and saved txt file.
  • tsview: ignore the excluded dates while fitting the time-functions

  • tsview: print out the specified command if --noverbose, similar to view.py

  • plot_network: auto-adjust the fig size / dpi for long time-series stack

  • scripts/load_data_aoi: add ionStack.h5 file crop/geocode

Reminders

  • Fix pixel coordinate discrepancy between view.py and reference_point.py #941
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ tsview: ignore the excluded dates while fitting the time-funcs

+ tsview: print out the specified command if --noverbose, similar to view.py

+ plot_network: auto-adjust the fig size / dpi for long time-series stack

+ scripts/load_data_aoi: add ionStack crop/geocode
+ utils.utils0.py: add get_lalo_digit4display() to calculate the the appropriate decimal places for the lat/lon coordinates for displaying puroose, based on the pixel size info in the metadata.

+ view.plot_slice(): call ut.get_lalo_digit4display() and use it in format_coord() for the status bar.

+ tsview: call ut.get_lalo_digit4display() in read_init_info() and use it in get_point_coord_str() for the figure title and saved txt file.

+ tsview: catch error for try/except while calling coord.radar2geo()
@yunjunz yunjunz changed the title (ts)view: auto-adjust the lat/lon decimal places + ignore ex date for time func fit (ts)view: auto-adjust lat/lon decimal places + ignore ex date for time func fit Dec 30, 2022
@yunjunz yunjunz merged commit aa390d2 into insarlab:main Dec 31, 2022
@yunjunz yunjunz deleted the plot branch December 31, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixel coordinate discrepancy between view.py and reference_point.py
1 participant