Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support hyp3 lv_phi file as azimuth angle #865

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Oct 10, 2022

Description of proposed changes

Reminders

  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ prep_hyp3.add_hyp3_metadata(): set UNIT to radian for "lv_phi" file

+ objects.stackDict.geometryDict(): convert hyp3 azimuthAngle input from gamma to mintpy/isce2 convention

+ docs: add lv_phi file to the example dir structure for hyp3
@yunjunz yunjunz changed the title support hyp3 lv_phi file as azimuth angle support hyp3 lv_phi file as azimuth angle Oct 10, 2022
Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me!

@forrestfwilliams
Copy link
Collaborator

Yep, looks good to me as well.

@yunjunz yunjunz merged commit 1350ddf into insarlab:main Oct 13, 2022
@yunjunz yunjunz deleted the hyp3 branch October 13, 2022 02:32
yuankailiu pushed a commit to yuankailiu/MintPy that referenced this pull request Oct 17, 2022
+ prep_hyp3.add_hyp3_metadata(): set UNIT to radian for "lv_phi" file

+ objects.stackDict.geometryDict():
   - convert hyp3 azimuthAngle input from gamma to mintpy/isce2 convention
   - convert no-data-value from 0 to nan for azimuthAngle and incidenceAngle

+ docs: add lv_phi file to the example dir structure for hyp3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants