Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo/test: add SanFranBaySenD42 for GMTSAR #1229

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Jul 18, 2024

Description of proposed changes

This PR adds the example GMTSAR datasets for MintPy inputs, as prepared by @Xiaohua-Eric-Xu.

  • docs: add SanFranBaySenD42 for GMTSAR

    • add docs/templates/SanFranBaySenD42.txt for GMTSAR
    • demo_dataset.md: add SanFranBaySenD42 for GMTSAR with figure (with DOI from zenodo)
    • use demo fig from github/insarlab/design-doc repo, instead of Yunjun's obsolete personal website, for better independency.
  • tests: add GMTSAR into the regular circle ci testing using example dataset from zenodo

    • add tests/configs/SanFranBaySenD42.txt
    • tests/smallbaselineApp.py: add SanFranBaySenD42 dataset with a false URL for place holder
    • add SanFranBaySenD42 to the regular Circle CI integration testing
  • load water mask for gmtsar, by adding:

    • objects.stackDict.geometryDict.write2hdf5(): convert NaN value to zero.
    • prep_gmtsar.prepare_geometry(): add all supported geometry data files, including water mask file
    • prep_gmtsar: add comments on input/output parameters for all functions.
  • utils.readfile._attribute_gmtsar2roipac: bugfix for ORBIT_DIRECTION

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Pass local test
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ docs: add SanFranBaySenD42 for GMTSAR
   - add docs/templates/SanFranBaySenD42.txt for GMTSAR
   - demo_dataset.md: add SanFranBaySenD42 for GMTSAR with figure (with DOI from zenodo)
   - use demo fig from github/insarlab/design-doc repo, instead of Yunjun's obsolete personal website, for better independency.

+ tests: add GMTSAR into the regular circle ci testing using example dataset from zenodo
   - add tests/configs/SanFranBaySenD42.txt
   - tests/smallbaselineApp.py: add SanFranBaySenD42 dataset with a false URL for place holder
   - add SanFranBaySenD42 to the regular Circle CI integration testing

+ load water mask for gmtsar, by adding:
   - objects.stackDict.geometryDict.write2hdf5(): convert NaN value to zero.
   - prep_gmtsar.prepare_geometry(): add all supported geometry data files, including water mask file
   - prep_gmtsar: add comments on input/output parameters for all functions.

+ utils.readfile._attribute_gmtsar2roipac: bugfix for ORBIT_DIRECTION
as gdal-3.9 could not read the geo-coordinate info properly from GMT *.grd files, which is generated by GMTSAR.
@yunjunz yunjunz merged commit 1a1f3e1 into insarlab:main Jul 19, 2024
6 of 7 checks passed
@yunjunz yunjunz deleted the gmtsar_demo branch July 19, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant